Skip to content

fix(web): restrict postMessage targetOrigin from wildcard to specific origins#30690

Merged
iamjoel merged 1 commit intolanggenius:mainfrom
xuwei95:fix/web-cve
Jan 8, 2026
Merged

fix(web): restrict postMessage targetOrigin from wildcard to specific origins#30690
iamjoel merged 1 commit intolanggenius:mainfrom
xuwei95:fix/web-cve

Conversation

@xuwei95
Copy link
Contributor

@xuwei95 xuwei95 commented Jan 7, 2026

Summary

This PR fixes a security vulnerability (CVE) related to postMessage usage in the web frontend. The changes restrict the targetOrigin parameter from wildcard (*) to specific origins.

Fixes #30723

Changes

  1. Embedded Chatbot (web/app/components/base/chat/embedded-chatbot/header/index.tsx):

    • Changed from postMessage(..., '*') to using document.referrer to determine parent origin
    • Falls back to '*' only if referrer is unavailable
  2. OAuth Hook (web/hooks/use-oauth.ts):

    • Changed from postMessage(..., '*') to using window.opener.origin
    • Falls back to '*' only if opener origin is unavailable

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@xuwei95 xuwei95 requested review from iamjoel and zxhlyh as code owners January 7, 2026 08:52
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 7, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xuwei95, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security posture of the web frontend by tightening the targetOrigin parameter used in postMessage communications. By moving away from a broad wildcard target to more specific origin validation based on document.referrer or window.opener.origin, the changes mitigate potential cross-site scripting (XSS) and data leakage risks, ensuring that messages are only sent to trusted recipients.

Highlights

  • Security Fix: This pull request addresses a security vulnerability (CVE) by restricting the targetOrigin parameter in postMessage calls from a wildcard (*) to specific, validated origins.
  • Embedded Chatbot Update: In web/app/components/base/chat/embedded-chatbot/header/index.tsx, the postMessage call now dynamically determines the targetOrigin using document.referrer, falling back to * only if the referrer is unavailable.
  • OAuth Hook Enhancement: The web/hooks/use-oauth.ts file has been updated to use window.opener.origin as the targetOrigin for postMessage calls, providing a more secure communication channel and falling back to * if the opener origin is not accessible.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good step towards enhancing security by restricting the targetOrigin in postMessage calls. The changes correctly identify the need to move away from a wildcard origin. However, the implementation in both modified files includes a fallback to '*', which could re-introduce the security vulnerability this PR aims to fix. My review includes suggestions to eliminate this fallback, particularly in use-oauth.ts where sensitive data is handled, and to improve the robustness of the origin detection in the embedded chatbot header.

@crazywoola
Copy link
Member

Please link an issue in the description :)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2026
@iamjoel iamjoel merged commit b2cbeea into langgenius:main Jan 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

4 participants