Skip to content

fix(web): resolve key-value input box height inconsistency on focus/blur (#30715)#30716

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
JunIce:fix-key-value-editor
Jan 8, 2026
Merged

fix(web): resolve key-value input box height inconsistency on focus/blur (#30715)#30716
crazywoola merged 1 commit intolanggenius:mainfrom
JunIce:fix-key-value-editor

Conversation

@JunIce
Copy link
Contributor

@JunIce JunIce commented Jan 8, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Fix #30715

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@JunIce JunIce requested review from iamjoel and zxhlyh as code owners January 8, 2026 01:26
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 8, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JunIce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a user interface inconsistency within the web application's key-value input boxes. Previously, these elements would exhibit varying heights upon focus or blur, leading to a jarring visual experience. The changes introduce precise styling modifications to guarantee a uniform height and correct vertical alignment for these input fields, thereby enhancing the overall visual stability and user interaction.

Highlights

  • UI Consistency Fix: Resolved an issue where key-value input boxes displayed inconsistent heights when gaining or losing focus, ensuring a stable visual experience.
  • Styling Adjustments: Applied specific Tailwind CSS classes to the input container and inner input elements to enforce a fixed height of 30px and proper vertical alignment.
  • Input Element Height: Ensured that both the editable Input components and the placeholder div within the key-value item consistently fill the full height of their parent containers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a height inconsistency in the key-value input component by setting a fixed height on the container and ensuring child elements fill this height. The approach seems sound and should resolve the described issue. I've included a couple of suggestions to improve code clarity and maintainability by addressing a potential typo in a class name and questioning the necessity of an !important CSS rule.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2026
@crazywoola crazywoola merged commit 27a803a into langgenius:main Jan 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

2 participants