Skip to content

feat: credit pool#30720

Merged
zyssyz123 merged 32 commits intomainfrom
feat/credit-pool
Jan 8, 2026
Merged

feat: credit pool#30720
zyssyz123 merged 32 commits intomainfrom
feat/credit-pool

Conversation

@zyssyz123
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 💪 enhancement New feature or request labels Jan 8, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zyssyz123, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a comprehensive credit pooling system to manage usage for hosted services, enhancing the platform's ability to handle trial and paid quotas for tenants. It also integrates support for new large language model providers and updates existing ones, providing a more flexible and scalable foundation for AI model consumption and billing. The changes ensure that credit usage is accurately tracked and reflected across the system, particularly in cloud environments.

Highlights

  • Credit Pooling System: Introduced a new credit pooling system for hosted services, allowing for centralized management of trial and paid credits for tenants. This includes a new database table tenant_credit_pools and a CreditPoolService.
  • New Hosted LLM Provider Support: Added configuration and integration for several new hosted LLM providers: Gemini, XAI, Deepseek, and Tongyi, expanding the range of available models.
  • Enhanced Quota Management: Updated the quota deduction logic to utilize the new credit pooling system for trial and paid quotas, ensuring accurate tracking and consumption of credits across different models and providers.
  • Expanded OpenAI Model List: Significantly expanded the list of supported OpenAI trial models, including various GPT-4, GPT-3.5, and upcoming GPT-4o and GPT-5 series models.
  • Workspace Information Enrichment: The workspace tenant information now includes details about trial_credits, trial_credits_used, and next_credit_reset_date for cloud deployments, providing better visibility into credit usage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a credit pool system for managing usage of hosted services, which is a significant and positive architectural change. The implementation is mostly solid, but I've identified a few critical issues, particularly a race condition in the credit deduction logic that could lead to incorrect billing. I've also found several minor copy-paste errors and typos. Addressing these points will improve the robustness and maintainability of this new feature.

zyssyz123 and others added 8 commits January 8, 2026 10:40
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

@hj24 hj24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2026
@zyssyz123 zyssyz123 merged commit fe08022 into main Jan 8, 2026
16 checks passed
@zyssyz123 zyssyz123 deleted the feat/credit-pool branch January 8, 2026 05:17
guangtouwangba pushed a commit to guangtouwangba/dify that referenced this pull request Jan 8, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

2 participants