feat(ops): set root span kind for AliyunTrace to enable service-level metrics aggregation#30728
Conversation
Summary of ChangesHello @hieheihei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the accuracy of service-level metrics aggregation within the Aliyun observability backend by correctly classifying root spans. By explicitly setting the "SpanKind" of initial traces to "SERVER", the Aliyun system can now properly track and report key performance indicators such as request rate, latency, and error rates, providing better insights into application performance. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly implements the setting of SpanKind for root spans in AliyunTrace to SERVER, which will enable proper service-level metrics aggregation in the Aliyun observability backend. The changes are well-structured: the SpanData entity is extended to carry the span_kind, the trace creation logic in aliyun_trace.py correctly identifies and sets the kind for root spans, and the traceclient is updated to use this new information. The use of a default SpanKind.INTERNAL ensures that existing code continues to function as before. The implementation is clean and effectively addresses the stated goal.
Important
Fixes #<issue number>.Summary
close #30863
Set root span kind to
SERVERfor AliyunTrace to enable service-level metrics aggregation in Aliyun observability backend.The Aliyun observability backend calculates service metrics based on span kind. Setting root spans to
SERVERenables proper service metrics tracking (request rate, latency, error rate).Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods