fix(web): invalidate app list cache after deleting app from detail page#30751
Conversation
When deleting an app from the app detail page (app-info sidebar), the app list cache was not being invalidated, causing the deleted app to still appear in the list after navigating back. This fix adds a call to invalidateAppList() after successful deletion, ensuring React Query's cache is properly invalidated and the app list reflects the deletion immediately. fixes langgenius#30746 Signed-off-by: majiayu000 <1835304752@qq.com>
Summary of ChangesHello @majiayu000, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the application list would not update immediately after an app was deleted from its detail page, leading to a stale UI. By integrating a cache invalidation mechanism directly into the app deletion process, the system now ensures that the app list accurately reflects the current state, providing a more consistent user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where the application list would become stale after deleting an app from its detail page. The introduction of invalidateAppList from React Query to invalidate the cache upon successful deletion is the right approach. The implementation is clean, and the new dependency has been correctly added to the useCallback hook. The changes are focused and effectively resolve the reported bug.
Summary
invalidateAppList()call after successful deletion inapp-info.tsxTest plan
fixes #30746
close #30752