Skip to content

fix(web): invalidate app list cache after deleting app from detail page#30751

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
majiayu000:fix/stale-app-list-after-deletion
Jan 9, 2026
Merged

fix(web): invalidate app list cache after deleting app from detail page#30751
crazywoola merged 1 commit intolanggenius:mainfrom
majiayu000:fix/stale-app-list-after-deletion

Conversation

@majiayu000
Copy link
Contributor

@majiayu000 majiayu000 commented Jan 8, 2026

Summary

  • Fix stale app list after deleting an app from the app detail page
  • Add invalidateAppList() call after successful deletion in app-info.tsx
  • Ensures React Query cache is properly invalidated when navigating back to app list

Test plan

  • Delete app from app detail page
  • Navigate back to app list
  • Verify deleted app no longer appears in list
  • Lint and type checks pass
  • Existing tests pass

fixes #30746
close #30752

When deleting an app from the app detail page (app-info sidebar), the app list cache was not being invalidated, causing the deleted app to still appear in the list after navigating back. This fix adds a call to invalidateAppList() after successful deletion, ensuring React Query's cache is properly invalidated and the app list reflects the deletion immediately. fixes langgenius#30746 Signed-off-by: majiayu000 <1835304752@qq.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 8, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @majiayu000, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the application list would not update immediately after an app was deleted from its detail page, leading to a stale UI. By integrating a cache invalidation mechanism directly into the app deletion process, the system now ensures that the app list accurately reflects the current state, providing a more consistent user experience.

Highlights

  • Cache Invalidation: Implemented useInvalidateAppList to ensure the React Query cache for the app list is properly invalidated.
  • App Deletion Flow: Added a call to invalidateAppList() within the handleDeleteApp function in app-info.tsx after a successful app deletion.
  • Dependency Management: Updated the dependency array for the handleDeleteApp callback to include invalidateAppList, ensuring correct behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue where the application list would become stale after deleting an app from its detail page. The introduction of invalidateAppList from React Query to invalidate the cache upon successful deletion is the right approach. The implementation is clean, and the new dependency has been correctly added to the useCallback hook. The changes are focused and effectively resolve the reported bug.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2026
@crazywoola crazywoola merged commit 9d9f027 into langgenius:main Jan 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

2 participants