Skip to content

fix: drop useless pyrefly in ci#30826

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
yihong0618:hy/drop_useless_check_in_ci
Jan 12, 2026
Merged

fix: drop useless pyrefly in ci#30826
crazywoola merged 1 commit intolanggenius:mainfrom
yihong0618:hy/drop_useless_check_in_ci

Conversation

@yihong0618
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

this do nothing and always fail

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Copilot AI review requested due to automatic review settings January 11, 2026 09:04
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 11, 2026
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a non-functional pyrefly check step from the CI workflow that was always failing but suppressed with || true, providing no actual value to the build pipeline.

Changes:

  • Removed pyrefly check step from the api-tests.yml GitHub Actions workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 12, 2026
@crazywoola crazywoola merged commit 9fad97e into langgenius:main Jan 12, 2026
16 of 17 checks passed
@asukaminato0721
Copy link
Contributor

(I use this to report issue to upstream.

example facebook/pyrefly#1792

@asukaminato0721
Copy link
Contributor

i move it here 547dff6

@yihong0618
Copy link
Contributor Author

(I use this to report issue to upstream.

example facebook/pyrefly#1792

copy that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

4 participants