build: limit esbuild, glob, docker base version to avoid cve#30848
build: limit esbuild, glob, docker base version to avoid cve#30848
Conversation
Summary of ChangesHello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the security of the web application by updating critical dependencies and the Docker build environment. Key changes include upgrading the Node.js Alpine Docker image and bumping the versions of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses security vulnerabilities by updating the Docker base image and several npm dependencies, including esbuild and glob. Pinning the Node.js version in the Dockerfile is a great improvement for build reproducibility and security. The dependency overrides in package.json are correctly placed to patch the CVEs.
I have one point of feedback regarding the version specified for the glob package override, which appears to be a version that is not publicly available and could cause issues.
There was a problem hiding this comment.
Pull request overview
This PR aims to address CVE vulnerabilities by updating dependency versions for esbuild, glob, and the Docker base image. However, the changes introduce critical issues with non-existent versions.
Changes:
- Updated esbuild version constraint from <0.25.0 to <0.27.2
- Added glob version override to force versions 10.2.0-10.5.0 to upgrade to 11.1.0
- Updated Docker base image from node:22-alpine3.21 to node:22.21.1-alpine3.23
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web/package.json | Updated esbuild and glob version overrides, removed esbuild from resolutions |
| web/pnpm-lock.yaml | Regenerated lockfile reflecting esbuild 0.27.2 throughout dependency tree |
| web/Dockerfile | Updated Docker base image to specify Node.js and Alpine versions |
Files not reviewed (1)
- web/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Important
Fixes #<issue number>.Summary
Fixes https://linear.app/dify/issue/DIFY-2429/dify-web
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods