Skip to content

build: limit esbuild, glob, docker base version to avoid cve#30848

Merged
douxc merged 3 commits intomainfrom
1-12-fix-cve
Jan 12, 2026
Merged

build: limit esbuild, glob, docker base version to avoid cve#30848
douxc merged 3 commits intomainfrom
1-12-fix-cve

Conversation

@hyoban
Copy link
Member

@hyoban hyoban commented Jan 12, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes https://linear.app/dify/issue/DIFY-2429/dify-web

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
Copilot AI review requested due to automatic review settings January 12, 2026 07:27
@hyoban hyoban requested a review from iamjoel as a code owner January 12, 2026 07:27
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Jan 12, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the security of the web application by updating critical dependencies and the Docker build environment. Key changes include upgrading the Node.js Alpine Docker image and bumping the versions of the esbuild and glob JavaScript packages to mitigate known vulnerabilities and ensure the use of more stable and secure releases.

Highlights

  • Docker Base Image Update: The Node.js Alpine base image for the web Dockerfile has been updated from node:22-alpine3.21 to node:22.21.1-alpine3.23 to ensure a more secure and up-to-date environment.
  • esbuild Dependency Upgrade: The esbuild dependency override in package.json and pnpm-lock.yaml has been updated from versions less than 0.25.0 to less than 0.27.2, addressing potential CVEs and leveraging newer features or fixes. An explicit esbuild dependency was also removed from package.json.
  • glob Dependency Update: A new override for the glob package has been introduced in package.json and pnpm-lock.yaml, limiting its version to glob@>=10.2.0,<10.5.0 and setting it to 11.1.0.
  • pnpm-lock.yaml Synchronization: The pnpm-lock.yaml file has been extensively updated to reflect the new esbuild and glob versions across all their transitive and platform-specific dependencies, ensuring consistency and security throughout the project's dependency tree.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses security vulnerabilities by updating the Docker base image and several npm dependencies, including esbuild and glob. Pinning the Node.js version in the Dockerfile is a great improvement for build reproducibility and security. The dependency overrides in package.json are correctly placed to patch the CVEs.

I have one point of feedback regarding the version specified for the glob package override, which appears to be a version that is not publicly available and could cause issues.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to address CVE vulnerabilities by updating dependency versions for esbuild, glob, and the Docker base image. However, the changes introduce critical issues with non-existent versions.

Changes:

  • Updated esbuild version constraint from <0.25.0 to <0.27.2
  • Added glob version override to force versions 10.2.0-10.5.0 to upgrade to 11.1.0
  • Updated Docker base image from node:22-alpine3.21 to node:22.21.1-alpine3.23

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
web/package.json Updated esbuild and glob version overrides, removed esbuild from resolutions
web/pnpm-lock.yaml Regenerated lockfile reflecting esbuild 0.27.2 throughout dependency tree
web/Dockerfile Updated Docker base image to specify Node.js and Alpine versions
Files not reviewed (1)
  • web/pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 12, 2026
@douxc douxc merged commit 00698e4 into main Jan 12, 2026
26 checks passed
@douxc douxc deleted the 1-12-fix-cve branch January 12, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

3 participants