Skip to content

fix: fix formatNumber accuracy#30877

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30869
Jan 13, 2026
Merged

fix: fix formatNumber accuracy#30877
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30869

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 13, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30869

fix formatNumber accuracy

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the formatNumber utility to ensure that very small numerical values are presented with full decimal precision rather than in scientific notation. This enhancement improves readability and accuracy for users interacting with small data points, ensuring a more intuitive display of numerical information across the application.

Highlights

  • Enhanced Number Formatting: The formatNumber utility function has been improved to prevent the display of very small numbers in scientific notation, ensuring they are shown with full decimal precision for better readability.
  • Dynamic Precision Calculation: New logic has been introduced within formatNumber to dynamically determine the appropriate decimal precision required to accurately represent small numbers, whether they originate from standard decimal or scientific notation inputs.
  • Comprehensive Test Coverage: Extensive unit tests have been added to validate the new formatting behavior, covering various scenarios including very small positive and negative numbers, as well as string inputs that might contain scientific notation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an accuracy issue in formatNumber for very small numbers. The approach is good, and the added tests are a great start. However, I've found a subtle bug in the new logic where numbers with multi-digit mantissas in scientific notation (e.g., 1.23e-7) would lose precision. I've provided a comment with a suggested fix for the implementation that also refactors the code to be more maintainable. I've also suggested an additional test case to cover this scenario and prevent future regressions. Overall, a good fix that will be even better with these adjustments.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 13, 2026
@crazywoola crazywoola merged commit 9ee7190 into langgenius:main Jan 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

2 participants