Revert return to null if manager is not found; add bool to throw exce… #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## 3.0.x #644 +/- ## ============================================ + Coverage 79.60% 79.62% +0.02% - Complexity 492 493 +1 ============================================ Files 73 73 Lines 1618 1620 +2 ============================================ + Hits 1288 1290 +2 Misses 330 330 ☔ View full report in Codecov by Sentry. |
Hermaniandr reviewed Nov 1, 2024
| /** | ||
| * Gets the object manager associated with a given class. | ||
| * | ||
| * @param class-string $className A persistent object class name. |
There was a problem hiding this comment.
We could add @return annotation, so static tools (e.g. phpstan) will understand that return type depends on argument
* @return ($throwExceptionIfNotFound is true ? ObjectManager : ObjectManager|null)
Hermaniandr approved these changes Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…ption instead