Update for Laravel 6 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We need to account for the fact that the default Bootstrap preset has been extracted to a separate package in laravel/ui and install this, before being able to run the Inertia.js preset over the top of it.
Typically you'll install the composer preset as a dev dependency, and may remove it for production, but we still need the inertia-laravel dependency in prod, otherwise everything breaks when it's removed.
Collaborator
| Curious, why do we even need the Bootstrap stuff for Inertia? |
Contributor Author
| The default views use Bootstrap because that’s what was included with Laravel when the initial version was built. They’d probably otherwise not be very exciting, or we’d have to make a decision on a) what to style them with or b) whether to include them at all. |
Contributor Author
| @reinink I've scrapped Bootstrap entirely, pulling in Tailwind (CDN version, to keep dependencies as light as possible).
I also found a way (per-Telescope) to inject a service provider into the |
reinink reviewed Sep 23, 2019
reinink approved these changes Sep 23, 2019
Collaborator
reinink left a comment
reinink left a comment There was a problem hiding this comment.
Love it! Using the CDN is a great way of handing this! 👌
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We need to account for the fact that the default Bootstrap preset has been extracted to a separate package in laravel/ui and install this, before being able to run the Inertia.js preset over the top of it.