Skip to content

Conversation

@timkelty
Copy link
Contributor

Was incorrectly checking for \Illuminate\Support\Stringable.

@taylorotwell taylorotwell merged commit 9626c3d into laravel:11.x Feb 17, 2025
44 checks passed
@sebdesign
Copy link
Contributor

sebdesign commented Feb 18, 2025

@taylorotwell This PR breaks implode on eloquent collections!

The Model implements the \Stringable interface, so the condition is never truthy when the collection contains eloquent models.

E.g. calling something like $posts->implode('title', ',') no longer implodes the plucked titles from the post models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants