Remove non-spec fields from resource content responses #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pushpak1300 added a commit that referenced this pull request Nov 24, 2025
* Remove non-spec fields from resource content responses * Update the minimum code coverage threshold to 91.7%
taylorotwell added a commit that referenced this pull request Nov 28, 2025
* Add Resource Template * Fix code styling * Add _meta support (#106) * Add meta and security scheme to tools * Fix phpstan definition * WIP 🚧 * WIP * Update the meta $property addition * Introduce `ResponseFactory` for handling responses with result-level metadata. * Replace `UnexpectedValueException` with `InvalidArgumentException` in `ResponseFactory` and improve type validation logic. * Formatting * Fix test and change the API * Refactor * Refactor * Update method signatures * Update Test * Improve testing --------- Co-authored-by: zacksmash <zachary.warren@me.com> # Conflicts: # tests/Unit/Methods/ReadResourceTest.php * Remove non-spec fields from resource content responses (#110) * Remove non-spec fields from resource content responses * Update the minimum code coverage threshold to 91.7% * Update CHANGELOG * Merge branch 'main' into add_support_for_resorce_templatees # Conflicts: # tests/Unit/Methods/ReadResourceTest.php * Fix code styling * Fix test * Refactor * Refactor * Add Test * Refactor * Add Test * Refactor UriTemplate methods * Refactor * Refactor * Refactor * Refactor * Add More Test * Add make:: method * Refactor Test * Refactor * Refactor * Fix Test * Refactor tools variable name * Formatting * SupportUriTemplate -> SupportsUriTemplate * improve numeric readability * Update the test coverage threshold * Remove redundant test * formatting * add files * formatting --------- Co-authored-by: zacksmash <zachary.warren@me.com> Co-authored-by: taylorotwell <463230+taylorotwell@users.noreply.github.com> Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Text and Blob content classes were including name and title fields in their toResource() output, which are not part of the MCP specification for resource contents.
Changes
According to the https://modelcontextprotocol.io/specification/2025-06-18/schema#textresourcecontents:
TextResourceContents should only include:
BlobResourceContents should only include:
The name and title fields belong to the resource descriptor itself, not the content payload.