Run golangci-lint on macOS and Windows; fix lint issues #3586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alexandear changed the title alexandear changed the title alexandear changed the title 
AkihiroSuda reviewed May 26, 2025
AkihiroSuda reviewed May 26, 2025
AkihiroSuda reviewed May 27, 2025
alexandear requested review from a team and AkihiroSuda and removed request for a team 
nirs reviewed Jun 4, 2025
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds
golangci-lintstep to run on Windows and macOS. And fixes a few lint issues that appeared on Windows and macOS.Fixes #3585