- Notifications
You must be signed in to change notification settings - Fork 15.3k
[Asan][RISCV] Support asan check for segment load/store RVV intrinsics. #100931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yetingk wants to merge 3 commits into llvm:main Choose a base branch from yetingk:asan-seg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits Select commit Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| //===--------- Definition of the MemoryRefInfo class -*- C++ -*------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This file defines MemoryRefInfo class that is used when getting | ||
| // the information of a memory reference instruction. | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| #ifndef LLVM_ANALYSIS_MEMORYREFINFO_H | ||
| #define LLVM_ANALYSIS_MEMORYREFINFO_H | ||
| | ||
| #include "llvm/IR/DataLayout.h" | ||
| #include "llvm/IR/Instruction.h" | ||
| #include "llvm/Support/TypeSize.h" | ||
| | ||
| namespace llvm { | ||
| class MemoryRefInfo { | ||
| public: | ||
| Use *PtrUse = nullptr; | ||
| bool IsWrite; | ||
| Type *OpType; | ||
| TypeSize TypeStoreSize = TypeSize::getFixed(0); | ||
| MaybeAlign Alignment; | ||
| // The mask Value, if we're looking at a masked load/store. | ||
| Value *MaybeMask; | ||
| // The EVL Value, if we're looking at a vp intrinsic. | ||
| Value *MaybeEVL; | ||
| // The Stride Value, if we're looking at a strided load/store. | ||
| Value *MaybeStride; | ||
| // The Offset Value, if we're looking at a indexed load/store. The | ||
| // offset actually means byte-offset instead of array index. | ||
| Value *MaybeOffset; | ||
| | ||
| MemoryRefInfo() = default; | ||
| MemoryRefInfo(Instruction *I, unsigned OperandNo, bool IsWrite, | ||
| class Type *OpType, MaybeAlign Alignment, | ||
| Value *MaybeMask = nullptr, Value *MaybeEVL = nullptr, | ||
| Value *MaybeStride = nullptr, Value *MaybeOffset = nullptr) | ||
| : IsWrite(IsWrite), OpType(OpType), Alignment(Alignment), | ||
| MaybeMask(MaybeMask), MaybeEVL(MaybeEVL), MaybeStride(MaybeStride), | ||
| MaybeOffset(MaybeOffset) { | ||
| const DataLayout &DL = I->getDataLayout(); | ||
| TypeStoreSize = DL.getTypeStoreSizeInBits(OpType); | ||
| PtrUse = &I->getOperandUse(OperandNo); | ||
| } | ||
| | ||
| Instruction *getInsn() { return cast<Instruction>(PtrUse->getUser()); } | ||
| Value *getPtr() { return PtrUse->get(); } | ||
| operator bool() { return PtrUse != nullptr; } | ||
| }; | ||
| | ||
| } // namespace llvm | ||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the patch is NFC which renames this class,
Can you please split "move and rename" into one patch, and functional change into another.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry that I merged the old pr contains the renaming part before seeing your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you still need this patch?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. I still need this patch. But it depeneds #100930.