[lit][aix] Always use internal lit shell on AIX #113355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @llvm/pr-subscribers-testing-tools Author: Daniel Paoliello (dpaoliello) ChangesDiff on AIX doesn't have all the required features used in tests (see <#108871> and <#112997 (comment)>), so always use the internal shell. Full diff: https://github.com/llvm/llvm-project/pull/113355.diff 1 Files Affected:
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py index 5f762ec7f3514a..1ef5796cd32e44 100644 --- a/llvm/utils/lit/lit/llvm/config.py +++ b/llvm/utils/lit/lit/llvm/config.py @@ -57,6 +57,13 @@ def __init__(self, lit_config, config): self.lit_config.note("using lit tools: {}".format(path)) lit_path_displayed = True + if platform.system() == "AIX": + # Diff on AIX doesn't have all the required features (see + # https://github.com/llvm/llvm-project/pull/108871 and + # https://github.com/llvm/llvm-project/pull/112997#issuecomment-2429656192) + # so always use the internal shell. + self.use_lit_shell = True + if platform.system() == "OS/390": self.with_environment("_BPXK_AUTOCVT", "ON") self.with_environment("_TAG_REDIR_IN", "TXT") |
abhina-sree added a commit to abhina-sree/llvm-project that referenced this pull request Oct 24, 2024
This reverts commit 4583dbc.
Closed
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
Diff on AIX doesn't have all the required features used in tests (see <llvm#108871> and <llvm#112997 (comment)>), so always use the internal shell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Diff on AIX doesn't have all the required features used in tests (see #108871 and #112997 (comment)), so always use the internal shell.