[llvm-exegesis][AArch64] Adding PR_PAC_APIAKEY macro definition #137888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @llvm/pr-subscribers-tools-llvm-exegesis Author: Haowei (zeroomega) ChangesIn older Linux distros, PR_PAC_APIAKEY is not defined and it causes build failures on linux arm64 platform. This patch adds the definition of this macro if it is not defined. Full diff: https://github.com/llvm/llvm-project/pull/137888.diff 1 Files Affected:
diff --git a/llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp b/llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp index 6d8e19e5820c7..aa34522cd7b7d 100644 --- a/llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp +++ b/llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp @@ -18,6 +18,9 @@ #ifndef PR_PAC_GET_ENABLED_KEYS #define PR_PAC_GET_ENABLED_KEYS 61 #endif +#ifndef PR_PAC_APIAKEY +#define PR_PAC_APIAKEY (1UL << 0) +#endif #endif #define GET_AVAILABLE_OPCODE_CHECKER |
| ✅ With the latest revision this PR passed the C/C++ code formatter. |
In older Linux distros, PR_PAC_APIAKEY is not defined and it causes build failures on linux arm64 platform. This patch adds the definition of this macro if it is not defined.
zeroomega force-pushed the exegesis_arm64 branch from 39c2865 to 3beacfa Compare Contributor Author
| C.C. @lakshayk-nv |
boomanaiden154 approved these changes Apr 29, 2025
Contributor
boomanaiden154 left a comment
boomanaiden154 left a comment There was a problem hiding this comment.
Looks good to me based on the kernel sources in https://github.com/torvalds/linux/blob/8bac8898fe398ffa3e09075ecea2be511725fb0b/include/uapi/linux/prctl.h#L227.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…#137888) In older Linux distros, PR_PAC_APIAKEY is not defined and it causes build failures on linux arm64 platform. This patch adds the definition of this macro if it is not defined.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
…#137888) In older Linux distros, PR_PAC_APIAKEY is not defined and it causes build failures on linux arm64 platform. This patch adds the definition of this macro if it is not defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In older Linux distros, PR_PAC_APIAKEY is not defined and it causes build failures on linux arm64 platform. This patch adds the definition of this macro if it is not defined.