[compiler-rt] Correctly detect cross-compiling for adding flags #138868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vitalybuka approved these changes May 10, 2025
fmayer approved these changes May 12, 2025
petrhosek approved these changes May 12, 2025
Member
petrhosek left a comment
petrhosek left a comment There was a problem hiding this comment.
Note that CMAKE_CROSSCOMPILING has a slightly different semantics, specifically it's TRUE whenever CMAKE_SYSTEM_NAME was set manually. I'd prefer using CMAKE_CROSSCOMPILING but it may be a potentially breaking change.
Collaborator
| Is this not needed any more? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This started with "Android is always cross-compiled" in commit aa9d74c, and continued with individual architectures like ARM in 6759fd9. Later Apple was carved out in 8887c63. I think we should just use the variable provided by CMake instead.