Format root clang-tidy config (NFC) #147902
Conversation
vbvictor requested review from 5chmidti, EugeneZelenko, PiotrZSL and carlosgalvezp 
carlosgalvezp left a comment
carlosgalvezp left a comment There was a problem hiding this comment.
LGTM. Worth noting is that the YAML list format is only supported since a few releases back, so it can break for users with older clang-tidy.
Thank you for noticing this, YAML list format is only 2 years old and LLVM promises backwards compatibility for 3 years of compilers. However, in CI we use Do we wish to support older versions of clang-tidy (that can't handle new config) or just stick to the latest one, WDYT? My opinion is that as LLVM developers, we should use the latest version of our tools (that will run in CI), so having a config with new format would not be a big deal. People who use LLVM as a library and don't run clang-tidy over LLVM code, or do they? |
| With this config, It's not a big deal. I will use format like in this one. |
I think it's reasonable to run Clang-Tidy after first stage (or subsequent stages) build with newly built executable, so it's always latest and greatest. Particular Clang-Tidy version is important to other projects which stick to some set of supported LLVM versions. |
vbvictor changed the title 
| Yep I think it's reasonable to use a fairly new version for our own project, so I'm fine with using the list format. Just threw it up in the air in case there was some use case I wasn't aware of :) |
| I think it's reasonable to use "old" format because it adds backwards compatibility with no readability drawbacks. |
From other side Clang-Tidy has a lot of fixes in existing checks, so it's not very reasonable to run too old versions. |
4 participants
Formatted config to column format, which is more readable.
Placed checks in alphabetical order.