[vscode-lldb] Fix yarn package

[royitaqi]

Problem

yarn package cannot be run twice in a row - the second time will error out:

Error: ENOENT: no such file or directory, stat '/llvm-project/lldb/tools/lldb-dap/out/lldb-dap.vsix'

This error is also weird, because the file actually exists. See the end of this full output.

Fix

Delete the lldb-dap.vsix file at the start of each run. See consecutive runs being successful.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: None (royitaqi)

Changes

Problem

yarn package cannot be run twice in a row - the second time will error out:
> Error: ENOENT: no such file or directory, stat '<path>/llvm-project/lldb/tools/lldb-dap/out/lldb-dap.vsix'

This error is also weird, because the file actually exists. See the end of this full output.

Fix

Delete the lldb-dap.vsix file at the start of each run. See consecutive runs being successful.

---

Full diff: https://github.com/llvm/llvm-project/pull/152002.diff

1 Files Affected:

• (modified) lldb/tools/lldb-dap/package.json (+1-1)

diff --git a/lldb/tools/lldb-dap/package.json b/lldb/tools/lldb-dap/package.json index 801abe73edd7d..11007b073fc44 100644 --- a/lldb/tools/lldb-dap/package.json +++ b/lldb/tools/lldb-dap/package.json @@ -45,7 +45,7 @@ "vscode:prepublish": "tsc -p ./", "watch": "tsc -watch -p ./", "format": "npx prettier './src-ts/' --write", - "package": "vsce package --out ./out/lldb-dap.vsix", + "package": "rm -rf ./out/lldb-dap.vsix && vsce package --out ./out/lldb-dap.vsix", "publish": "vsce publish", "vscode-uninstall": "code --uninstall-extension llvm-vs-code-extensions.lldb-dap", "vscode-install": "code --install-extension ./out/lldb-dap.vsix" 

[walter-erquinigo]

good catch

[royitaqi]

Hi @walter-erquinigo,

Thanks for the review.

Asking just for this first time: In this code base (vscode-lldb), do you recommend me to go ahead and merge with your approval, or should I wait for @JDevlieghere to take a look, too?

[JDevlieghere]

Asking just for this first time: In this code base (vscode-lldb), do you recommend me to go ahead and merge with your approval, or should I wait for @JDevlieghere to take a look, too?

Thanks for asking! The Code Review Policy touches on some of the nuances, but generally you can merge with one approval. I can still provide feedback as a post-commit review. That's a little harder for bigger/invasive/complicated patches (which usually also require more time to review), so waiting a little longer for those is generally appreciated. But a PR like this you can definitely merge.