Skip to content

Conversation

@jryans
Copy link
Member

@jryans jryans commented Oct 17, 2025

This fixes a few typos noticed while browsing around IR-related files.

This fixes a few typos noticed while browsing around IR-related files.
@llvmbot
Copy link
Member

llvmbot commented Oct 17, 2025

@llvm/pr-subscribers-llvm-ir

@llvm/pr-subscribers-debuginfo

Author: J. Ryan Stinnett (jryans)

Changes

This fixes a few typos noticed while browsing around IR-related files.


Full diff: https://github.com/llvm/llvm-project/pull/163957.diff

3 Files Affected:

  • (modified) llvm/include/llvm/IR/DebugProgramInstruction.h (+5-5)
  • (modified) llvm/include/llvm/IR/Value.h (+2-2)
  • (modified) llvm/lib/IR/DebugInfo.cpp (+5-5)
diff --git a/llvm/include/llvm/IR/DebugProgramInstruction.h b/llvm/include/llvm/IR/DebugProgramInstruction.h index e0292c2b8d2d2..457c60e3bc929 100644 --- a/llvm/include/llvm/IR/DebugProgramInstruction.h +++ b/llvm/include/llvm/IR/DebugProgramInstruction.h @@ -14,7 +14,7 @@ // dbg.value(metadata i32 %foo, ...) // %bar = void call @ext(%foo); // -// and all information is stored in the Value / Metadata hierachy defined +// and all information is stored in the Value / Metadata hierarchy defined // elsewhere in LLVM. In the "DbgRecord" design, each instruction /may/ have a // connection with a DbgMarker, which identifies a position immediately before // the instruction, and each DbgMarker /may/ then have connections to DbgRecords @@ -37,7 +37,7 @@ // // This structure separates the two concerns of the position of the debug-info // in the function, and the Value that it refers to. It also creates a new -// "place" in-between the Value / Metadata hierachy where we can customise +// "place" in-between the Value / Metadata hierarchy where we can customise // storage and allocation techniques to better suite debug-info workloads. // NB: as of the initial prototype, none of that has actually been attempted // yet. @@ -162,7 +162,7 @@ class DbgRecord : public ilist_node<DbgRecord> { LLVM_ABI bool isIdenticalToWhenDefined(const DbgRecord &R) const; /// Convert this DbgRecord back into an appropriate llvm.dbg.* intrinsic. /// \p InsertBefore Optional position to insert this intrinsic. - /// \returns A new llvm.dbg.* intrinsic representiung this DbgRecord. + /// \returns A new llvm.dbg.* intrinsic representing this DbgRecord. LLVM_ABI DbgInfoIntrinsic * createDebugIntrinsic(Module *M, Instruction *InsertBefore) const; ///@} @@ -530,7 +530,7 @@ class DbgVariableRecord : public DbgRecord, protected DebugValueUser { LLVM_ABI void setKillAddress(); /// Check whether this kills the address component. This doesn't take into /// account the position of the intrinsic, therefore a returned value of false - /// does not guarentee the address is a valid location for the variable at the + /// does not guarantee the address is a valid location for the variable at the /// intrinsic's position in IR. LLVM_ABI bool isKillAddress() const; @@ -539,7 +539,7 @@ class DbgVariableRecord : public DbgRecord, protected DebugValueUser { LLVM_ABI DbgVariableRecord *clone() const; /// Convert this DbgVariableRecord back into a dbg.value intrinsic. /// \p InsertBefore Optional position to insert this intrinsic. - /// \returns A new dbg.value intrinsic representiung this DbgVariableRecord. + /// \returns A new dbg.value intrinsic representing this DbgVariableRecord. LLVM_ABI DbgVariableIntrinsic * createDebugIntrinsic(Module *M, Instruction *InsertBefore) const; diff --git a/llvm/include/llvm/IR/Value.h b/llvm/include/llvm/IR/Value.h index 04d0391c04098..58822a0645747 100644 --- a/llvm/include/llvm/IR/Value.h +++ b/llvm/include/llvm/IR/Value.h @@ -484,8 +484,8 @@ class Value { /// Remove every uses that can safely be removed. /// /// This will remove for example uses in llvm.assume. - /// This should be used when performing want to perform a tranformation but - /// some Droppable uses pervent it. + /// This should be used when performing want to perform a transformation but + /// some Droppable uses prevent it. /// This function optionally takes a filter to only remove some droppable /// uses. LLVM_ABI void diff --git a/llvm/lib/IR/DebugInfo.cpp b/llvm/lib/IR/DebugInfo.cpp index 14a4f88bf4719..2e16e9091fa33 100644 --- a/llvm/lib/IR/DebugInfo.cpp +++ b/llvm/lib/IR/DebugInfo.cpp @@ -294,7 +294,7 @@ void DebugInfoFinder::processSubprogram(DISubprogram *SP) { // just DISubprogram's, referenced from anywhere within the Function being // cloned prior to calling MapMetadata / RemapInstruction to avoid their // duplication later as DICompileUnit's are also directly referenced by - // llvm.dbg.cu list. Thefore we need to collect DICompileUnit's here as well. + // llvm.dbg.cu list. Therefore we need to collect DICompileUnit's here as well. // Also, DICompileUnit's may reference DISubprogram's too and therefore need // to be at least looked through. processCompileUnit(SP->getUnit()); @@ -377,7 +377,7 @@ bool DebugInfoFinder::addScope(DIScope *Scope) { /// Recursively handle DILocations in followup metadata etc. /// -/// TODO: If for example a followup loop metadata would refence itself this +/// TODO: If for example a followup loop metadata would reference itself this /// function would go into infinite recursion. We do not expect such cycles in /// the loop metadata (except for the self-referencing first element /// "LoopID"). However, we could at least handle such situations more gracefully @@ -679,7 +679,7 @@ class DebugTypeInfoRemoval { auto Variables = nullptr; auto TemplateParams = nullptr; - // Make a distinct DISubprogram, for situations that warrent it. + // Make a distinct DISubprogram, for situations that warrant it. auto distinctMDSubprogram = [&]() { return DISubprogram::getDistinct( MDS->getContext(), FileAndScope, MDS->getName(), LinkageName, @@ -2043,7 +2043,7 @@ void at::remapAssignID(DenseMap<DIAssignID *, DIAssignID *> &Map, I.setMetadata(LLVMContext::MD_DIAssignID, GetNewID(ID)); } -/// Collect constant properies (base, size, offset) of \p StoreDest. +/// Collect constant properties (base, size, offset) of \p StoreDest. /// Return std::nullopt if any properties are not constants or the /// offset from the base pointer is negative. static std::optional<AssignmentInfo> @@ -2329,7 +2329,7 @@ PreservedAnalyses AssignmentTrackingPass::run(Function &F, return PreservedAnalyses::all(); // Record that this module uses assignment tracking. It doesn't matter that - // some functons in the module may not use it - the debug info in those + // some functions in the module may not use it - the debug info in those // functions will still be handled properly. setAssignmentTrackingModuleFlag(*F.getParent()); 
@github-actions

This comment was marked as resolved.

Copy link
Contributor

@OCHyams OCHyams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty

@jryans jryans merged commit 6b36cfa into llvm:main Oct 17, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants