[MIR2Vec] Fix to skip tests in MIR2VecEmbeddingTestFixture #164467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @llvm/pr-subscribers-mlgo Author: S. VenkataKeerthy (svkeerthy) ChangesFixes test failure issues (caused by #162161) in Windows buildbots. Full diff: https://github.com/llvm/llvm-project/pull/164467.diff 1 Files Affected:
diff --git a/llvm/unittests/CodeGen/MIR2VecTest.cpp b/llvm/unittests/CodeGen/MIR2VecTest.cpp index 8cd9d5ac9f6be..8710d6b45969a 100644 --- a/llvm/unittests/CodeGen/MIR2VecTest.cpp +++ b/llvm/unittests/CodeGen/MIR2VecTest.cpp @@ -255,6 +255,10 @@ class MIR2VecEmbeddingTestFixture : public MIR2VecVocabTestFixture { void SetUp() override { MIR2VecVocabTestFixture::SetUp(); + // If base class setup was skipped (TII not initialized), skip derived setup + if (!TII) + GTEST_SKIP() << "Failed to get target instruction info in " + "the base class setup; Skipping test"; // Create a dummy function for MachineFunction FunctionType *FT = FunctionType::get(Type::getVoidTy(*Ctx), false); |
mtrofin approved these changes Oct 21, 2025
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
Fixes test failure issues (caused by llvm#162161) in Windows buildbots.
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
Fixes test failure issues (caused by llvm#162161) in Windows buildbots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes test failure issues (caused by #162161) in Windows buildbots.