Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

These check lines were added in 144dae2
as part of reenabling on Linux. The check lines were added using an or
clause though that gets short circuited, so were never actually
executed. Fixing the short circuit so they do execute reveals the
filecheck assertions no longer pass. Remove them for now given they did
not exist in the original test.

This would cause failures on the internal shell given the ()
syntax is not understood by the internal shell.

@llvmbot
Copy link
Member

llvmbot commented Nov 5, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Aiden Grossman (boomanaiden154)

Changes

These check lines were added in 144dae2
as part of reenabling on Linux. The check lines were added using an or
clause though that gets short circuited, so were never actually
executed. Fixing the short circuit so they do execute reveals the
filecheck assertions no longer pass. Remove them for now given they did
not exist in the original test.

This would cause failures on the internal shell given the (<command>)
syntax is not understood by the internal shell.


Full diff: https://github.com/llvm/llvm-project/pull/166638.diff

1 Files Affected:

  • (modified) compiler-rt/test/hwasan/TestCases/Linux/fixed-shadow.c (+2-4)
diff --git a/compiler-rt/test/hwasan/TestCases/Linux/fixed-shadow.c b/compiler-rt/test/hwasan/TestCases/Linux/fixed-shadow.c index fc83b213561c8..08a04fc305ffb 100644 --- a/compiler-rt/test/hwasan/TestCases/Linux/fixed-shadow.c +++ b/compiler-rt/test/hwasan/TestCases/Linux/fixed-shadow.c @@ -3,12 +3,12 @@ // Default compiler instrumentation works with any shadow base (dynamic or fixed). // RUN: %clang_hwasan %s -o %t // RUN: %run %t -// RUN: env HWASAN_OPTIONS=fixed_shadow_base=263878495698944 %run %t 2>%t.out || (cat %t.out | FileCheck %s) +// RUN: env HWASAN_OPTIONS=fixed_shadow_base=263878495698944 %run %t // RUN: env HWASAN_OPTIONS=fixed_shadow_base=4398046511104 %run %t // // If -hwasan-mapping-offset is set, then the fixed_shadow_base needs to match. // RUN: %clang_hwasan %s -mllvm -hwasan-mapping-offset=263878495698944 -o %t -// RUN: env HWASAN_OPTIONS=fixed_shadow_base=263878495698944 %run %t 2>%t.out || (cat %t.out | FileCheck %s) +// RUN: env HWASAN_OPTIONS=fixed_shadow_base=263878495698944 %run %t // RUN: env HWASAN_OPTIONS=fixed_shadow_base=4398046511104 not %run %t // RUN: %clang_hwasan %s -mllvm -hwasan-mapping-offset=4398046511104 -o %t @@ -26,8 +26,6 @@ // // UNSUPPORTED: android -// CHECK: FATAL: HWAddressSanitizer: Shadow range {{.*}} is not available - #include <assert.h> #include <sanitizer/allocator_interface.h> #include <sanitizer/hwasan_interface.h> 
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
@boomanaiden154 boomanaiden154 changed the base branch from users/boomanaiden154/main.compiler-rthwasan-remove-check-lines-from-test to main November 6, 2025 01:59
boomanaiden154 added a commit to boomanaiden154/llvm-project that referenced this pull request Nov 6, 2025
These check lines were added in 144dae2 as part of reenabling on Linux. The check lines were added using an or clause though that gets short circuited, so were never actually executed. Fixing the short circuit so they do execute reveals the filecheck assertions no longer pass. Remove them for now given they did not exist in the original test. This would cause failures on the internal shell given the (<command>) syntax is not understood by the internal shell. Pull Request: llvm#166638
@boomanaiden154 boomanaiden154 merged commit 9f5811e into main Nov 6, 2025
14 of 16 checks passed
@boomanaiden154 boomanaiden154 deleted the users/boomanaiden154/compiler-rthwasan-remove-check-lines-from-test branch November 6, 2025 08:06
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Nov 6, 2025
These check lines were added in 144dae2 as part of reenabling on Linux. The check lines were added using an or clause though that gets short circuited, so were never actually executed. Fixing the short circuit so they do execute reveals the filecheck assertions no longer pass. Remove them for now given they did not exist in the original test. This would cause failures on the internal shell given the (<command>) syntax is not understood by the internal shell. Reviewers: vitalybuka, thurstond, fmayer Reviewed By: vitalybuka Pull Request: llvm/llvm-project#166638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants