[Lex] Use a range-based for loop (NFC) #169174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Identified with modernize-loop-convert.
llvmbot added clang 
Member
| @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) ChangesIdentified with modernize-loop-convert. Full diff: https://github.com/llvm/llvm-project/pull/169174.diff 1 Files Affected:
diff --git a/clang/lib/Lex/Preprocessor.cpp b/clang/lib/Lex/Preprocessor.cpp index e003ad3a95570..0a25dc19548ec 100644 --- a/clang/lib/Lex/Preprocessor.cpp +++ b/clang/lib/Lex/Preprocessor.cpp @@ -1458,10 +1458,8 @@ void Preprocessor::removeCommentHandler(CommentHandler *Handler) { bool Preprocessor::HandleComment(Token &result, SourceRange Comment) { bool AnyPendingTokens = false; - for (std::vector<CommentHandler *>::iterator H = CommentHandlers.begin(), - HEnd = CommentHandlers.end(); - H != HEnd; ++H) { - if ((*H)->HandleComment(*this, Comment)) + for (CommentHandler *H : CommentHandlers) { + if (H->HandleComment(*this, Comment)) AnyPendingTokens = true; } if (!AnyPendingTokens || getCommentRetentionState()) |
tgymnich approved these changes Nov 22, 2025
kazutakahirata deleted the cleanup_20251122_clang_tidy_modernize-loop-convert_Lex branch aadeshps-mcw pushed a commit to aadeshps-mcw/llvm-project that referenced this pull request Nov 26, 2025
Identified with modernize-loop-convert.
Priyanshu3820 pushed a commit to Priyanshu3820/llvm-project that referenced this pull request Nov 26, 2025
Identified with modernize-loop-convert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Identified with modernize-loop-convert.