[lldb] Fix duplicate test class name causing lldb-dotest conflict

[da-viper]

Duplicate test class name TestFrameVarDILPointerArithmetic prevents lldb-dotest from running any tests.
The conflict exists between:

• lldb/test/API/commands/frame/vardil/expr/PointerArithmetic/
• lldb/test/API/commands/frame/vardil/basics/PointerArithmetic/

Rename the expr variant to TestFrameVarDILExprPointerArithmetic.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Ebuka Ezike (da-viper)

Changes

Duplicate test class name TestFrameVarDILPointerArithmetic prevents lldb-dotest from running any tests.
The conflict exists between:

• lldb/test/API/commands/frame/vardil/expr/PointerArithmetic/
• lldb/test/API/commands/frame/vardil/basics/PointerArithmetic/

Rename the expr variant to TestFrameVarDILExprPointerArithmetic.

---

Full diff: https://github.com/llvm/llvm-project/pull/169861.diff

1 Files Affected:

• (renamed) lldb/test/API/commands/frame/var-dil/expr/PointerArithmetic/TestFrameVarDILExprPointerArithmetic.py (+1-1)

diff --git a/lldb/test/API/commands/frame/var-dil/expr/PointerArithmetic/TestFrameVarDILPointerArithmetic.py b/lldb/test/API/commands/frame/var-dil/expr/PointerArithmetic/TestFrameVarDILExprPointerArithmetic.py similarity index 93% rename from lldb/test/API/commands/frame/var-dil/expr/PointerArithmetic/TestFrameVarDILPointerArithmetic.py rename to lldb/test/API/commands/frame/var-dil/expr/PointerArithmetic/TestFrameVarDILExprPointerArithmetic.py index 88429b370710e..448cd5b1ec7e0 100644 --- a/lldb/test/API/commands/frame/var-dil/expr/PointerArithmetic/TestFrameVarDILPointerArithmetic.py +++ b/lldb/test/API/commands/frame/var-dil/expr/PointerArithmetic/TestFrameVarDILExprPointerArithmetic.py @@ -8,7 +8,7 @@ from lldbsuite.test import lldbutil -class TestFrameVarDILPointerArithmetic(TestBase): +class TestFrameVarDILExprPointerArithmetic(TestBase): NO_DEBUG_INFO_TESTCASE = True def test_pointer_arithmetic(self): 

[DavidSpickett]

LGTM

On the surface this sounds like a pretty silly restriction, but I can't remember what the reason for it is. Probably because the test framework makes a giant pile of Python classes, right? So not something we would be able to fix easily.

Not a big deal, just wondering.

[da-viper]

Probably because the test framework makes a giant pile of Python classes, right?

Yeah and it is easier to do lldb-dotest -p TestClass.py without resolving the actual path to the test.

[DavidSpickett]

Yeah and it is easier

Definitely, I would be the first to complain if we took away that feature :)

[Michael137]

LGTM

On the surface this sounds like a pretty silly restriction, but I can't remember what the reason for it is. Probably because the test framework makes a giant pile of Python classes, right? So not something we would be able to fix easily.

Not a big deal, just wondering.

This comes up every once in a while: #137681 (comment)