Skip to content

Conversation

@vinayakdsci
Copy link
Contributor

Removes unused header includes from strfrom*() implementation files.

@llvmbot llvmbot added the libc label Mar 26, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 26, 2024

@llvm/pr-subscribers-libc

Author: Vinayak Dev (vinayakdsci)

Changes

Removes unused header includes from strfrom*() implementation files.


Full diff: https://github.com/llvm/llvm-project/pull/86657.diff

3 Files Affected:

  • (modified) libc/src/stdlib/strfromd.cpp (-3)
  • (modified) libc/src/stdlib/strfromf.cpp (-3)
  • (modified) libc/src/stdlib/strfroml.cpp (-3)
diff --git a/libc/src/stdlib/strfromd.cpp b/libc/src/stdlib/strfromd.cpp index 1d02a7ad112442..329f6fdcaff731 100644 --- a/libc/src/stdlib/strfromd.cpp +++ b/libc/src/stdlib/strfromd.cpp @@ -9,9 +9,6 @@ #include "src/stdlib/strfromd.h" #include "src/stdlib/str_from_util.h" -#include <stdarg.h> -#include <stddef.h> - namespace LIBC_NAMESPACE { LLVM_LIBC_FUNCTION(int, strfromd, diff --git a/libc/src/stdlib/strfromf.cpp b/libc/src/stdlib/strfromf.cpp index 40eff87eb454c5..80e1d74797c80b 100644 --- a/libc/src/stdlib/strfromf.cpp +++ b/libc/src/stdlib/strfromf.cpp @@ -9,9 +9,6 @@ #include "src/stdlib/strfromf.h" #include "src/stdlib/str_from_util.h" -#include <stdarg.h> -#include <stddef.h> - namespace LIBC_NAMESPACE { LLVM_LIBC_FUNCTION(int, strfromf, diff --git a/libc/src/stdlib/strfroml.cpp b/libc/src/stdlib/strfroml.cpp index 6b8781e7c04e11..f0bc9354c7ad76 100644 --- a/libc/src/stdlib/strfroml.cpp +++ b/libc/src/stdlib/strfroml.cpp @@ -9,9 +9,6 @@ #include "src/stdlib/strfroml.h" #include "src/stdlib/str_from_util.h" -#include <stdarg.h> -#include <stddef.h> - namespace LIBC_NAMESPACE { LLVM_LIBC_FUNCTION(int, strfroml, 
Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! Are you able to merge or do you need one of us to?

@vinayakdsci
Copy link
Contributor Author

Thanks for the patch! Are you able to merge or do you need one of us to?

No, I will need someone to merge this for me, I don't have write access. Thanks!

@michaelrj-google michaelrj-google merged commit 2d97ba2 into llvm:main Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants