[CompilerRT] Apply CMake INTDIR substitution for Ninja Multi-Config build #87918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…uild On Ninja Multi-Config mode configuration of CMake, CompilerRT used to generate a directory that contains unexpanded ${CONFIGURATION}. After this change, the variable is expanded for each configuration types. 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
On Ninja Multi-Config mode configuration, CompilerRT generates its output to a weird directory, such as
${CONFIGURATION}/lib/clang/19/lib/x86_64-pc-linux-gnu/libclang_rt.builtins.awhich contains unexpanded
${CONFIGURATION}as a directory name.That causes a build error around syms-stamp on my environment.
After this patch applied,
${CONFIGURATION}will be expanded to corresponding build configs such as Debug, Release, and RelWithDebInfo.We can see similar expansion in AddLLVM.cmake.