Skip to content

fix: Duplicate title bars when showing system title bar#1021

Merged
GT-610 merged 3 commits intolollipopkit:mainfrom
GT-610:fix/titlebar
Jan 22, 2026
Merged

fix: Duplicate title bars when showing system title bar#1021
GT-610 merged 3 commits intolollipopkit:mainfrom
GT-610:fix/titlebar

Conversation

@GT-610
Copy link
Collaborator

@GT-610 GT-610 commented Jan 22, 2026

Resolve #956.

Due to behavioral changes in the fl_lib package, this PR cannot be merged until lollipopkit/fl_lib/pull/11 is merged into the main branch of fl_lib.

Summary by CodeRabbit

  • Chores
    • Updated window frame display configuration for improved desktop window behavior.
    • Upgraded core library dependency to a newer development revision to incorporate recent fixes and enhancements.

✏️ Tip: You can customize this high-level summary in your review settings.

When initializing the window, add the configuration to set the title bar display, ensuring consistency with user settings
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Two files changed: lib/main.dart now calls WindowFrameConfig.setShowCaption(hideTitleBar) during window init (before SystemUIs.initDesktopWindow), and pubspec.yaml updates the fl_lib git ref from v1.0.358 to v1.0.359.

Changes

Cohort / File(s) Summary
Window Configuration
lib/main.dart
Added WindowFrameConfig.setShowCaption(hideTitleBar) in _initWindow, invoked before SystemUIs.initDesktopWindow, using the existing hideTitleBar value to set caption visibility.
Dependency Update
pubspec.yaml
Updated fl_lib git dependency reference from v1.0.358 to v1.0.359.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main fix addressing duplicate title bars when the system title bar is shown, which matches the PR's core objective.
Linked Issues check ✅ Passed The PR implements the required fix by adding WindowFrameConfig.setShowCaption(hideTitleBar) call and updating fl_lib to v1.0.359, directly addressing issue #956's duplicate title bar problem.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the duplicate title bar issue: the code addition handles title bar visibility and the dependency update provides required behavioral fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0411a37 and ccd3f46.

⛔ Files ignored due to path filters (1)
  • pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pubspec.yaml
🧰 Additional context used
📓 Path-based instructions (1)
pubspec.yaml

📄 CodeRabbit inference engine (CLAUDE.md)

Use hive_ce instead of hive for Hive integration

Files:

  • pubspec.yaml
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR Repo: lollipopkit/flutter_server_box PR: 0 File: CLAUDE.md:0-0 Timestamp: 2025-10-08T09:36:41.682Z Learning: Applies to lib/view/**/*.dart : Prefer widgets/utilities from fl_lib for common UI (e.g., CustomAppBar, context.showRoundDialog, Input, Btnx.cancelOk) 
🔇 Additional comments (1)
pubspec.yaml (1)

66-69: No action required. Verification confirms v1.0.359 exists upstream and pubspec.lock is properly aligned with the same ref and resolved commit hash.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0411a372e7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 22, 2026
@GT-610 GT-610 merged commit e49b31e into lollipopkit:main Jan 22, 2026
2 checks passed
@GT-610 GT-610 deleted the fix/titlebar branch January 22, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant