Skip to content

fix: Update dependencies and add a cancel button to the color selection dialog#1025

Merged
GT-610 merged 2 commits intolollipopkit:mainfrom
GT-610:feat/color-cancel
Jan 24, 2026
Merged

fix: Update dependencies and add a cancel button to the color selection dialog#1025
GT-610 merged 2 commits intolollipopkit:mainfrom
GT-610:feat/color-cancel

Conversation

@GT-610
Copy link
Collaborator

@GT-610 GT-610 commented Jan 24, 2026

  • Update the fl_lib dependency to version v1.0.362
  • Add a cancel button in the color selection dialog to enhance user experience

Summary by CodeRabbit

  • Improvements

    • Color seed editing dialog now includes a dedicated Cancel button alongside the confirm action for clearer user intent.
  • Chores

    • Updated internal dependencies to latest compatible versions.

✏️ Tip: You can customize this high-level summary in your review settings.

…on dialog Update the fl_lib dependency to version v1.0.362 Add a cancel button in the color selection dialog to enhance user experience
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

The pull request modifies the color seed editing dialog in app settings to include explicit Cancel and OK actions in a modal action bar, and bumps the fl_lib dependency from v1.0.361 to v1.0.362. The dialog previously had a single OK button; now it explicitly handles cancellation.

Changes

Cohort / File(s) Summary
Color Seed Dialog Actions
lib/view/page/setting/entries/app.dart
Changed dialog actions from single OK button to modal action bar with Cancel (closes without saving) and OK (saves via _onSaveColor(ctrl.text)) actions.
Dependency Update
pubspec.yaml
Updated fl_lib Git dependency from v1.0.361 to v1.0.362 (repository URL also changed from lppcg/fl_lib to lollipopkit/fl_lib).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • lollipopkit
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes both main changes: updating dependencies and adding a cancel button to the color selection dialog.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🧹 Recent nitpick comments
lib/view/page/setting/entries/app.dart (1)

346-349: Consider using Btn.cancel/Btn.ok for consistency.

This dialog uses raw TextButton widgets while the newly updated color dialog uses Btn.cancel/Btn.ok from fl_lib. Consider updating this for consistency across dialogs.

♻️ Suggested refactor for consistency
 actions: [ - TextButton(onPressed: () => context.pop(null), child: Text(libL10n.cancel)), - TextButton(onPressed: () => context.pop(controller.text.trim()), child: Text(libL10n.ok)), + Btn.cancel(onTap: () => context.pop(null)), + Btn.ok(onTap: () => context.pop(controller.text.trim())), ],
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d47c9d and 885c0fc.

⛔ Files ignored due to path filters (1)
  • pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • lib/view/page/setting/entries/app.dart
  • pubspec.yaml
🧰 Additional context used
📓 Path-based instructions (2)
lib/view/**/*.dart

📄 CodeRabbit inference engine (CLAUDE.md)

lib/view/**/*.dart: Prefer widgets/utilities from fl_lib for common UI (e.g., CustomAppBar, context.showRoundDialog, Input, Btnx.cancelOk)
Prefer using libL10n strings before adding new ones to project l10n
Split UI into build, actions, and utils; use extension on to separate concerns

Files:

  • lib/view/page/setting/entries/app.dart
pubspec.yaml

📄 CodeRabbit inference engine (CLAUDE.md)

Use hive_ce instead of hive for Hive integration

Files:

  • pubspec.yaml
🧠 Learnings (2)
📚 Learning: 2025-10-08T09:36:41.682Z
Learnt from: CR Repo: lollipopkit/flutter_server_box PR: 0 File: CLAUDE.md:0-0 Timestamp: 2025-10-08T09:36:41.682Z Learning: Applies to lib/view/**/*.dart : Prefer widgets/utilities from fl_lib for common UI (e.g., CustomAppBar, context.showRoundDialog, Input, Btnx.cancelOk) 

Applied to files:

  • lib/view/page/setting/entries/app.dart
  • pubspec.yaml
📚 Learning: 2025-10-08T09:36:41.682Z
Learnt from: CR Repo: lollipopkit/flutter_server_box PR: 0 File: CLAUDE.md:0-0 Timestamp: 2025-10-08T09:36:41.682Z Learning: Applies to lib/view/**/*.dart : Split UI into build, actions, and utils; use extension on to separate concerns 

Applied to files:

  • lib/view/page/setting/entries/app.dart
🔇 Additional comments (2)
lib/view/page/setting/entries/app.dart (1)

137-140: Good use of fl_lib button utilities.

The implementation correctly uses Btn.cancel and Btn.ok from fl_lib, which aligns with the coding guidelines. The Cancel button properly dismisses the dialog, and the OK button delegates to the existing _onSaveColor handler.

Based on the learnings mentioning Btnx.cancelOk, you might want to verify if there's a combined utility in fl_lib that could simplify this pattern further, but the current implementation is clean and correct.

pubspec.yaml (1)

66-69: The fl_lib dependency repository and version tag are valid.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot requested a review from lollipopkit January 24, 2026 16:01
@GT-610 GT-610 merged commit e226fec into lollipopkit:main Jan 24, 2026
2 checks passed
@GT-610 GT-610 deleted the feat/color-cancel branch January 24, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant