Skip to content

fix: version code err caused by Flutter#913

Merged
lollipopkit merged 1 commit intomainfrom
lollipopkit/issue906
Sep 14, 2025
Merged

fix: version code err caused by Flutter#913
lollipopkit merged 1 commit intomainfrom
lollipopkit/issue906

Conversation

@lollipopkit
Copy link
Owner

Fixes #906

@lollipopkit
Copy link
Owner Author

@claude review

@claude
Copy link

claude bot commented Sep 14, 2025

Claude finished @lollipopkit's task —— View job


Code Review Complete ✅

Todo List:

Review Summary

The Fix: This PR changes the version code calculation multiplier from 10 to 100 in the Android build configuration (android/app/build.gradle:116).

- output.versionCodeOverride = variant.versionCode * 10 + abiVersionCode + output.versionCodeOverride = variant.versionCode * 100 + abiVersionCode

Analysis

✅ Positive Aspects:

  1. Targeted Fix: The change is minimal and focused, addressing a specific version code calculation issue
  2. Preserves Logic: The overall ABI-based versioning strategy remains intact
  3. Non-Breaking: This change shouldn't affect app functionality, only version numbering

⚠️ Considerations:

  1. Version Code Spacing:

    • Before: With multiplier 10, ABIs would be numbered like: 1231, 1232, 1233 (for version 123)
    • After: With multiplier 100, ABIs will be numbered like: 12301, 12302, 12303 (for version 123)
    • This provides more spacing between different app versions, which is good for avoiding conflicts
  2. ABI Codes Context: The change works with the existing ABI codes:

    ext.abiCodes = ["x86_64": 1, "armeabi-v7a": 2, "arm64-v8a": 3]

    So the final version codes will end in 01, 02, or 03 respectively.

  3. Google Play Compatibility: The new version codes will be significantly higher, but Google Play Store supports version codes up to 2,100,000,000, so this shouldn't be an issue.

Recommendation: APPROVE

This is a clean, focused fix that addresses the version code calculation issue mentioned in #906. The change from multiplier 10 to 100 provides better separation between app versions and their ABI variants, which should prevent the version code conflicts that were likely occurring.

No issues found - the change is safe to merge.

@lollipopkit lollipopkit merged commit d7168ea into main Sep 14, 2025
1 check passed
@lollipopkit lollipopkit deleted the lollipopkit/issue906 branch September 14, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant