Always show both stdout and stderr for code blocks#189
Always show both stdout and stderr for code blocks#189mmlb wants to merge 4 commits intomaaslalani:mainfrom
Conversation
I noticed that the non-stdlib imports were split into 2 groups, seemingly randomly. No other file does this so I just brought it back to one group and let goimports sort it.
Any output that is printed may still be useful even if the command returns an error so lets display it. Printing out even in case of error is fine, if there's no output and output.Write handles that fine. I tested this by trying to run a code block for a language I do not have the compiler for.
Code blocks may try to print to stderr which is currently dropped.
51b5f71 to 8ae6fd2 Compare | Gentle ping to @maaslalani |
| Thanks @mmlb! |
| @mmlb I'm not a huge fan of the error messages produce by the Alternatively, I wonder if we can scrub the file name from the |
| Yeah agree about that. I would not like to have a different key binding, I can take a look at dropping the filename. |
| @maaslalani I've pushed a quick hack to get rid of the name (only tested on go and bash atm) how's this error output look? I'm not a fan of the |
| Gentle ping, @maaslalani and @mmlb |
| Looking for any feedback |
| Hey @mmlb, I don't like the idea of the |
| Another option is to log to a temporary file which people can inspect? |


Changes Introduced