Suggested changes for CUDA build #209
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These changes were made mostly because the CUDA Dockerfile in the project, while successfully building FFmpeg, didn't recognize
nvencfor me. I made some changes that made it work.Main Changes:
deviceQueryfrom CUDA Samples incuda-ubuntu.dockerfileso compute capability can be detected automatically. Default values are still hard-coded inside the build script, and can be overridden by setting theCUDA_COMPUTE_CAPABILITYenv variable.CURRENT_PACKAGE_VERSIONmore so as to reduce redundancy.nvccflags. Since NVIDIA's own examples do this, I don't think anything is going to break.Other Changes:
libzmqsupportlibsdl(It's not working for me for some reason) to use SDL's Github release page insteadzlib, for the same reason, to use Madler's Github release page insteadThe final image containing the binary is still around 650MB.