Fixed issue where x265.pc file would be missing if git isn't installed #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| Thanks, I added the git part from the pull request. Best, Markus |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Took me awhile to track this one down but there's an issue where the x265.pc file isn't generated if git isn't installed.
--skip-ffmpeg-buildoption to skip ffmpeg build and just build the other libs. This made debugging the build happening inside a container little easier because I could split my command into two different statements in the Dockerfile.--enable-gpl-and-non-free. If someone uses this Dockerfile as a starting point it's now obvious that git is needed.