Fix TouchPointer NullReferenceException#11036
Merged
RogPodge merged 1 commit intomicrosoft:mainfrom Sep 20, 2022
Merged
Conversation
|
|
RogPodge approved these changes Sep 20, 2022
Contributor
RogPodge left a comment
RogPodge left a comment There was a problem hiding this comment.
Interesting that the InputSourceParent could end up being null. This starts digging a bit deep into the implementation of the libraries raising these input sources, but I think we should be good if adding these safeguards stops the propogation of errors.
Contributor
| @keveleigh when you get back for visibility |
AlihanAt pushed a commit to AlihanAt/ARMaps that referenced this pull request Dec 5, 2022
Bug das Buttons auf Android nicht funktionierten. Sollte somit behoben sein. Link: microsoft/MixedRealityToolkit-Unity#11036
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixed the NullReferenceException that occurs when using the TouchPointer on mobile devices (MRTK 2.8.2).
Changes