impl FromLua for serde_json::Value #302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
khvzak force-pushed the master branch 2 times, most recently from 94cef89 to 59b1400 Compare khvzak force-pushed the master branch 4 times, most recently from 166f9c2 to f1ceaf0 Compare 
| this is amazing |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request introduces the implementation of the
FromLuatrait forserde_json::Value. This will allow smooth conversion from Lua values to serde_json values and get rid of the'lualifetime, providing better integration and flexibility.Details:
Added a new feature flag for json:
A new feature flag named
jsonhas been added, dependent on both theserializefeature and theserde_jsoncrate. This allows the conditional compilation of the new implementation, ensuring backward compatibility.Updated Cargo.toml:
serde_jsonas an optional dependency, with version"1.0".Updated src/value.rs:
FromLuatrait forserde_json::Value.from_luamethod, a value of Lua type is converted to aserde_json::Value, handling any potential conversion errors and wrapping them into theError::FromLuaConversionError.