Retry flaky unified tests #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
katcharov requested review from a team and vbabanin and removed request for a team katcharov force-pushed the JAVA-5393-unified-retries branch from 6282ce7 to 8e8d7a3 Compare katcharov force-pushed the JAVA-5393-unified-retries branch from 8e8d7a3 to 6f3b56d Compare katcharov force-pushed the JAVA-5393-unified-retries branch from d24e003 to 6b53427 Compare 
katcharov commented Dec 5, 2024
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java Show resolved Hide resolved
katcharov force-pushed the JAVA-5393-unified-retries branch from 86681ad to 3b2c915 Compare katcharov commented Dec 5, 2024
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java Outdated Show resolved Hide resolved
katcharov commented Dec 6, 2024
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java Show resolved Hide resolved
katcharov force-pushed the JAVA-5393-unified-retries branch from ce1918c to 784dc51 Compare katcharov force-pushed the JAVA-5393-unified-retries branch from 784dc51 to f62539e Compare katcharov commented Feb 4, 2025
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java Show resolved Hide resolved
vbabanin reviewed Feb 25, 2025
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java Outdated Show resolved Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java Show resolved Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java Show resolved Hide resolved
vbabanin reviewed Mar 6, 2025
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java Show resolved Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java Outdated Show resolved Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java Outdated Show resolved Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java Show resolved Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java Outdated Show resolved Hide resolved
vbabanin approved these changes Mar 13, 2025
Member
vbabanin left a comment
vbabanin left a comment There was a problem hiding this comment.
LGTM! Great addition to enhance test stability, @katcharov !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JAVA-5795
See WRITING-28651
This creates N copies (attempts) of the unified tests, and places a try-catch around shouldPassAllOutcomes. If an attempt passes, ensuing attempts are ignored. Failures are ignored, except the last attempt.
This is not intended to fully resolve the issue, but is a low-cost fix that should reduce failing tests.