Skip to content

Improve selection criteria for srvMaxHosts #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Improve selection criteria for srvMaxHosts #1590

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c86824b
update applySrvMaxHosts
joykim1005 Dec 26, 2024
14657f7
update srvMaxHost logic
joykim1005 Dec 31, 2024
b7e793a
refactor
joykim1005 Jan 13, 2025
a35dc0b
refactor
joykim1005 Jan 14, 2025
9b7ec84
Merge branch 'mongodb:main' into JAVA-4400
joykim1005 Jan 14, 2025
025557f
update with suggestion
joykim1005 Jan 15, 2025
71ea834
fix checkstyle
joykim1005 Jan 15, 2025
28351a7
fix checkstyle
joykim1005 Jan 15, 2025
fb20033
Merge branch 'main' into JAVA-4400
joykim1005 Jan 15, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix checkstyle
  • Loading branch information
@joykim1005
joykim1005 committed Jan 15, 2025
commit 71ea834d5cb16e36fdfae437a261b98838b0cd33
5 changes: 2 additions & 3 deletions driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.concurrent.ThreadLocalRandom;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -71,7 +70,7 @@ private Collection<ServerAddress> applySrvMaxHosts(final Collection<ServerAddres
return activeHosts;
}

private List<ServerAddress> getActivePriorHosts(Collection<ServerAddress> latestSrvHosts) {
private List<ServerAddress> getActivePriorHosts(final Collection<ServerAddress> latestSrvHosts) {
List<ServerAddress> priorHosts = DnsMultiServerCluster.this.getCurrentDescription().getServerDescriptions().stream()
.map(ServerDescription::getAddress).collect(Collectors.toList());
priorHosts.removeIf(host -> !latestSrvHosts.contains(host));
Expand All @@ -80,7 +79,7 @@ private List<ServerAddress> getActivePriorHosts(Collection<ServerAddress> latest
}

private List<ServerAddress> addShuffledHosts(final Collection<ServerAddress> latestSrvHosts,
List<ServerAddress> activePriorHosts, int numNewHostsToAdd) {
final List<ServerAddress> activePriorHosts, final int numNewHostsToAdd) {
List<ServerAddress> addedHosts = new ArrayList<>(latestSrvHosts);
addedHosts.removeAll(activePriorHosts);
Collections.shuffle(addedHosts, ThreadLocalRandom.current());
Expand Down