Added regression tests for "number" alias in $$type operator. #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rozza requested review from a team and NathanQingyangXu and removed request for a team 
NathanQingyangXu approved these changes Apr 29, 2025
| if (expectedTypes.isString()) { | ||
| types = singletonList(expectedTypes.asString().getValue()); | ||
| String expectedType = expectedTypes.asString().getValue(); | ||
| if (expectedType.equals("number")) { |
Contributor
There was a problem hiding this comment.
Discussion only. Nothing needs to be done.
I know in this specific case, expectedfType can't be null, but generally speaking, it is a good practice to put string constant to the left hand side of equals() method to avoid NPE.
if ("number".equals(expectedType)) { Not a big deal for sure.
Contributor
| LGTM. Tested successfully locally. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JAVA-5682