Fix static check warnings. #1696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JAVA-5800
JAVA-5800
stIncMale reviewed Apr 30, 2025
Member
stIncMale left a comment
stIncMale left a comment There was a problem hiding this comment.
There is still
> Task :bson:javadoc /Users/valentin.kovalenko/Documents/programming/projects/mongo-java-driver/bson/src/main/org/bson/io/OutputBuffer.java:200: warning: no comment protected int writeCharacters(final String str, final boolean checkForNullCharacters) { This warning was introduced by JAVA-5816.
Member Author
Thanks! I am planning to address it in a separate PR #1697 to keep PRs and commits linked to separate tickets. |
stIncMale approved these changes Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes static analysis warnings introduced in JAVA-5800. Also renamed variables in related methods - using "b" for a long/int values was unclear and has been replaced with more descriptive names.
JAVA-5800