Fix Netty reference leak. #1762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes netty byte buffer releases in edge case scenarios: - Ensure async select server uses a callback if the cluster had been closed - Ensure that handleReadResponse checks to see if the cluster had been closed before retaining incoming buffers - Ensure closing the netty stream releases all references Test fixes - Ensure tests run using paranoid leak detection - Fail the testsuite if a leak is detected. - Fixed releasing buffers in the ByteBufferBsonOutputTest. JAVA-5901
vbabanin reviewed Jul 10, 2025
Member
vbabanin left a comment
vbabanin left a comment There was a problem hiding this comment.
Looks good! Just one suggestion.
driver-core/src/main/com/mongodb/internal/connection/netty/NettyStream.java Show resolved Hide resolved
…tyStream.java Co-authored-by: Viacheslav Babanin <frest0512@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes netty byte buffer releases in edge case scenarios:
Test fixes
JAVA-5901