Make event metric type, object metric type, and ping Sendable#3255
Merged
badboy merged 1 commit intomozilla:mainfrom Sep 29, 2025
Merged
Make event metric type, object metric type, and ping Sendable#3255badboy merged 1 commit intomozilla:mainfrom
badboy merged 1 commit intomozilla:mainfrom
Conversation
badboy reviewed Sep 19, 2025
Member
badboy left a comment
badboy left a comment There was a problem hiding this comment.
test failures unrelated, I also kicked the iOS tests for good measure.
badboy force-pushed the cr/1987503_more-sendable-metrics branch from b1b15e2 to d4413f0 Compare badboy approved these changes Sep 29, 2025
Contributor
| Hi @badboy, do you know when we can expect the next release with these changes? 🙏 Thanks! |
Member
I have some other pending changes that I want to wrap up in a release within the next week or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Sendable conformance to:
Some of these conformances are marked as unchecked sendable. TODO comments added to make these unchecked sendable in this bugzilla ticket https://bugzilla.mozilla.org/show_bug.cgi?id=1987503