Conversation
Create nep-10.mediawiki
NFT changes
Remove tokenURI
Update tokensOf and the metadata schema
| } | ||
| </pre> | ||
| | ||
| Returns the total amount of NFTs owned by the specified address. |
There was a problem hiding this comment.
What is the supposed return value of this method for divisible NFTs? They have an overloaded balanceOf which is quite obvious, but they at the same time have this one also (with owner parameter only) and if some owner has 0.5 of token A and 0.125 of token B then what is the total amount of divisible NFTs owned?
There was a problem hiding this comment.
But does it have any meaning? These tokens are non-fungible and it can be like you own 0.5 of some house and 0.125 of the other, you don't own 0.625 of anything.
| I think we may benefit from a couple of amendments to the NFT metadata schema. Firstly, not all NFTs are images, they can be any form of content, such as music or a piece of writing. So maybe we should replace the "image" parameter with something more generalized (maybe "asset" or "content"). Secondly, I think we should include the content's SHA256 hash as a value in the schema. A commonly discussed problem right now in the Ethereum community is that a URI can easily be changed to point to something completely different; currently there are many cases of NFT images that are being replaced with pictures of rugs (for "rug pull"). Obviously an NFT isn't really used to actually store the original content so this issue isn't directly a problem for us, but I think it should always be possible to verify what content an NFT should point to. Therefore I think it is very important to store the hash. |
The NFT metadata schema is expandable. You can add custom fields. Currently described are some well-known fields. |
shargon changed the title | Merge? Or anyone has any comments? |
WyattMufson left a comment
WyattMufson left a comment There was a problem hiding this comment.
It's now been more than 3 years since this was started, seems ready to merge
erikzhang dismissed stale reviews from vncoelho, WyattMufson, and shargon via 2de0d5a 
| Please merge! Will be great to have a finalised, accepted and merged standard that the community can build upon. |
| @erikzhang what else is needed to merge this is in? |
13 participants
Originally posted by @hal0x2328 in #41.