proposal: NeoFS block storage format#194
proposal: NeoFS block storage format#194AliceInHunterland wants to merge 2 commits intoneo-project:masterfrom
Conversation
roman-khimov left a comment
roman-khimov left a comment There was a problem hiding this comment.
Index files? Synchronization algorithm?
| @AliceInHunterland please update accordingly, this is not likely can be reviewed with any useful suggestions from other coredevs since we know little about neofs, please just follow roman's suggestion |
AliceInHunterland force-pushed the neofs-blocks branch from 1c6106c to 674a1c2 Compare AliceInHunterland force-pushed the neofs-blocks branch 2 times, most recently from 1231891 to 6c12fbe Compare 
neofs-blocks.mediawiki Outdated
| An [https://rest.fs.neo.org/v1/objects/3RCdP3ZubyKyo8qFeo7EJPryidTZaGCMdUjqFJaaEKBV/by_id/Fu7yQzspvLJwSGJNK64xeeyMdWXtU5B5b1es6KSxUag1 example] | ||
| of a block object is as follows: | ||
| <pre> | ||
| ID: Fu7yQzspvLJwSGJNK64xeeyMdWXtU5B5b1es6KSxUag1 | ||
| CID: 3RCdP3ZubyKyo8qFeo7EJPryidTZaGCMdUjqFJaaEKBV | ||
| Owner: NVvY1FF67XJ2GTVhy9FqiZGC4jEQtvjmHt |
There was a problem hiding this comment.
Is it correct to attach object link as an example? This object/container may be removed in future whereas we expect NEP to be consistent. @roman-khimov?
There was a problem hiding this comment.
Example can be a proper example with this data if needed. It doesn't imply any of the IDs are relevant for mainnet or whatever else.
AliceInHunterland force-pushed the neofs-blocks branch from 6c12fbe to bf44b35 Compare 
AnnaShaleva force-pushed the neofs-blocks branch 3 times, most recently from b02aabe to b795db3 Compare AnnaShaleva requested review from Jim8y, Wi1l-B0t, cschuchardt88, shargon and vncoelho 
| @roman-khimov, let's review one more time. |
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AnnaShaleva force-pushed the neofs-blocks branch from b795db3 to 6b50aeb Compare 
| LGTM. I prefer to approve the general logic as long as its correct and complete, then polish the format later. |
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
| @neo-project/core let's review this proposal one more time. |
shargon left a comment
shargon left a comment There was a problem hiding this comment.
TimeStampfor upload time seems very similar to BlockTime, maybe useUploadedTimeorStoredAtinstead could be more clear- It's possible to recover a block range 1-1000 ? without 1000 requests?
Impossible. It's a part of NeoFS protocol since like forever: https://github.com/nspcc-dev/neofs-api/blame/2fb0e588670ecbaf7b40fe105d1e84cdf91de7e3/object/types.proto#L251
1 SEARCH + 1000 GETs. |
6 participants
No description provided.