Skip to content

fix wrong sync status in auto upload on white theming#4924

Merged
AndyScherzinger merged 1 commit intomasterfrom
theming_auto_upload
Dec 3, 2019
Merged

fix wrong sync status in auto upload on white theming#4924
AndyScherzinger merged 1 commit intomasterfrom
theming_auto_upload

Conversation

@tobiasKaminsky
Copy link
Member

fix #4855

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11821.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

333

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings104
Security Warnings44
Dodgy code Warnings136
Total407

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings104
Security Warnings44
Dodgy code Warnings136
Total407
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #4924 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@ ## master #4924 +/- ## ============================================ - Coverage 17.72% 17.72% -0.01%  Complexity 3 3 ============================================ Files 384 384 Lines 32650 32650 Branches 4597 4597 ============================================ - Hits 5788 5787 -1  - Misses 25938 25941 +3  + Partials 924 922 -2
Impacted Files Coverage Δ Complexity Δ
...ncloud/android/ui/adapter/SyncedFolderAdapter.java 13.14% <0%> (ø) 0 <0> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 80.95% <0%> (-2.39%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 50% <0%> (-1.58%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.17% <0%> (+0.08%) 0% <0%> (ø) ⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java 26.81% <0%> (+1%) 0% <0%> (ø) ⬇️
@AndyScherzinger AndyScherzinger merged commit cd86ff1 into master Dec 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the theming_auto_upload branch December 3, 2019 12:54
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Dec 3, 2019
tobiasKaminsky added a commit that referenced this pull request Dec 4, 2019
7cf3ba9 Merge pull request #4925 from nextcloud/NotNull cd86ff1 Merge pull request #4924 from nextcloud/theming_auto_upload 2f9c5e9 replace org.jetbrains.annotations with androidx.annotations 83903ea fix wrong sync status in auto upload on white theming 2dbf724 [tx-robot] updated from transifex 2d68e2e daily dev 20191203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants