feat(web): add checkboxes to control plot bubbles and confidence lines#16
Open
ivan-aksamentov wants to merge 1 commit intomasterfrom
Open
feat(web): add checkboxes to control plot bubbles and confidence lines#16ivan-aksamentov wants to merge 1 commit intomasterfrom
ivan-aksamentov wants to merge 1 commit intomasterfrom
Conversation
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested followup of: #11
/!\ WORK IN PROGRESS
As I suggested in the PR above, here I add recoil atoms to keep state (and remember it in the Local Storage), as well as checkbox elements, which would control display of bubbles and lines.
I hooked up the
shouldShowBubblesstate to completely disable the rendering ofCustomizedDot. The rest is not connected yet.This is merely a suggestion. We may or may not take this path. The exact logic may change according to projects' needs. We may keep checkboxes or use other UI elemets as appropriate. The 3 checkboxes give
9 combinations8 combinations* of possible plot experiences. Not all of them may make sense. We can try to limit number of checkboxes, or to use for example 2-way switch toggles (or 3-way, or N-way) or a dropdown menu instead.(Click "Visit preview" to see the preview deployment app on Vercel)
--
* - combinatorics is hard, sigh