Fix channel declaration error in the cadd subworkflow#624
Merged
ramprasadn merged 1 commit intodevfrom Oct 4, 2024
Merged
Conversation
|
1 similar comment
|
fellen31 approved these changes Oct 4, 2024
Contributor
fellen31 left a comment
There was a problem hiding this comment.
👍
All tests are stub only right? Could you also "run" CADD then with just a mock path?
Collaborator Author
| Thanks for the review @fellen31. IIRC, the reason we don’t run CADD is that we encounter storage issues on GitHub actions. This is one such workflow that rarely changes so its off by default. Planniing to implement subworkflow level tests soon so that should help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).