ENH: Permit XmlSerializable.to_xml() to pass kwargs to ElementTree.tostring() #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #1258 +/- ## ========================================== + Coverage 92.19% 92.22% +0.02% ========================================== Files 99 99 Lines 12458 12454 -4 Branches 2560 2560 ========================================== Hits 11486 11486 + Misses 648 644 -4 Partials 324 324
☔ View full report in Codecov by Sentry. |
effigies force-pushed the enh/xml-kwargs branch from 6a4736c to f8c940d Compare 
Member Author
| In the absence of objections, merging. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Small quality-of-life improvement when wanting to experiment with XML serializable structures.