RF: Deprecate longdouble<->int hacks #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
effigies changed the title 
Member Author
| @matthew-brett You added these back in #70, but I think I'm right that they can go away at this point. Any objections? Any other regression tests worth putting in? @larsoner or @mscheltienne Would you mind having a review, since you were just dealing with these? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## master #1272 +/- ## ========================================== - Coverage 92.25% 92.21% -0.04% ========================================== Files 99 99 Lines 12466 12455 -11 Branches 2564 2561 -3 ========================================== - Hits 11500 11486 -14 - Misses 643 645 +2 - Partials 323 324 +1
☔ View full report in Codecov by Sentry. |
Member Author
| Thanks for the review! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We had a pair of functions
as_int()andint_to_float()that handled bugs in numpy that existed at least as recently as 1.11, but which no longer exist in 1.20, our current minimum.This PR replaces
as_int(...)withint(...)andint_to_float(..., dtype)withdtype(...)and deprecates these functions. Regression tests to ensure that these native Python/numpy functions work as expected are retained.