RF: Remove unnecessary call to asbytes for b-prepended strings #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1331 +/- ## ======================================= Coverage 92.20% 92.20% ======================================= Files 98 98 Lines 12400 12400 Branches 2557 2557 ======================================= Hits 11433 11433 Misses 644 644 Partials 323 323 ☔ View full report in Codecov by Sentry. |
jhlegarreta force-pushed the FixNpCompatWarning branch from ee62634 to 26862ac Compare Remove unnecessary call to `asbytes` for `b`-prepended strings: strings prepended with `b` are already treated as bytes literals: - `TckFile.MAGIC_NUMBER` is b'mrtrix tracks' - `TrkFile.MAGIC_NUMBER` is b'TRACK' Documentation: https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals Fixes: ``` /home/runner/work/nibabel/nibabel/nibabel/streamlines/tests/test_streamlines.py:9: DeprecationWarning: `np.compat`, which was used during the Python 2 to 3 transition, is deprecated since 1.26.0, and will be removed from numpy.compat.py3k import asbytes ``` raised for example at: https://github.com/nipy/nibabel/actions/runs/9637811213/job/26577586721#step:7:178
jhlegarreta force-pushed the FixNpCompatWarning branch from 26862ac to d1235a6 Compare jhlegarreta changed the title "b" to mark byte literalsasbytes for b-prepended strings Contributor Author
|
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove unnecessary call to
asbytesforb-prepended strings: stringsprepended with
bare already treated as bytes literals:TckFile.MAGIC_NUMBERis b'mrtrix tracks'TrkFile.MAGIC_NUMBERis b'TRACK'Documentation:
https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals
Fixes:
raised for example at:
https://github.com/nipy/nibabel/actions/runs/9637811213/job/26577586721#step:7:178