fix(git-node): ignore all non-gha nodes when checking for GitHub CI

[aduh95]

Implements #838 (comment). The problem has come back now that we have a new jenkins-node-js-ci (see nodejs/admin#916), and IMO it only makes sense to check for GHA-related jobs only when checking the state of the GitHub CI.

[VoltrexKeyva]

Suggested change

	if (app.slug !== 'github-actions') {
	if (app && app.slug !== 'github-actions') {

[avivkeller]

Suggested change

	if (app.slug !== 'github-actions') {
	if (app?.slug !== 'github-actions') {

a suggestion upon your suggestion

[aduh95]

I'm not sure this is needed.

[targos]

The problem has come back now that we have a new jenkins-node-js-ci

Now I don't understand:

• How this can affect "production" jobs. I have only tried to use the plugin on a copy of the linter job
• How can I see these checks? I have still been unable to see any effect of the option on the job copy (in GitHub UI or Jenkins output).

[aduh95]

• How can I see these checks?

One way is to apply the following diff and run git node land on a PR which head branch in on nodejs/node.

diff --git a/lib/pr_checker.js b/lib/pr_checker.js index 064c647..129b9a5 100644 --- a/lib/pr_checker.js +++ b/lib/pr_checker.js @@ -381,6 +381,7 @@ export default class PRChecker { } if (status !== 'COMPLETED') { + console.log(checkSuites.nodes); cli.error('GitHub CI is still running'); return false; } @@ -395,6 +396,7 @@ export default class PRChecker { if (commit.status) { const { state } = commit.status; if (state === 'PENDING') { + console.log(checkSuites.nodes); cli.error('GitHub CI is still running'); return false; }