src: add support for locally installed headers#2964
Merged
lukekarrys merged 7 commits intonodejs:mainfrom Jan 29, 2024
Merged
Conversation
Some linux distros allow headers to be installed through tools like rpm. If the runtime sets process.config.variables.use_prefix_to_find_headers, look for matching headers based on the directory set for the prefix in process.config.variables.prefix Signed-off-by: Michael Dawson <midawson@redhat.com>
Member Author
| Not sure if this should be added to doc, if so just let me know and I'll look for the right place. |
Member Author
| Upstream PR in Node.js to allow setting use_prefix_to_find_headers - nodejs/node#51525 |
Member Author
| Note that the addition to test/test-configure-python.js was needed so that the tests would run ok when applied to other streams, and does not adversely affect testing in head |
Member Author
| From the test failure on windows, I do see the test is too linux specific will take a look. |
Signed-off-by: Michael Dawson <midawson@redhat.com>
Member Author
| Guess it was more than just the path, spinning up a windows machine to investigate on. |
Signed-off-by: Michael Dawson <midawson@redhat.com>
Member Author
| Ok, windows all fixed up :) |
richardlau reviewed Jan 19, 2024
lukekarrys approved these changes Jan 29, 2024
Member
lukekarrys left a comment
lukekarrys left a comment There was a problem hiding this comment.
LGTM! One minor suggestion to only expose readFileSync.
lukekarrys reviewed Jan 29, 2024
lukekarrys added a commit that referenced this pull request Dec 2, 2024
Some linux distros allow headers to be installed through tools like rpm. If the runtime sets process.config.variables.use_prefix_to_find_headers, look for matching headers based on the directory set for the prefix in process.config.variables.prefix Signed-off-by: Michael Dawson <midawson@redhat.com> Co-authored-by: Luke Karrys <luke@lukekarrys.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
Some linux distros allow headers to be installed through tools like rpm. If the runtime sets
process.config.variables.use_prefix_to_find_headers, look for matching headers based on the directory set for the prefix in process.config.variables.prefix